Minor error/s

Posted in

#226 by sakurakoi
2017-06-05 at 06:49
when we don't want to define the gender.
Do you (2nd person plural, not singular) just refuse to assume a gender?!

Well, seriously...
It reads much better than writing "he or she".
to be simply fair, they (see what I did here) suggested not that but "this character" which in the context of the vndb would simple quite be suitable and more precise if indeed just a single character is always meant.

Though might as well keep "they" to keep the usage high lest that fact is not known to even more (wasn't actually taught that in school ever either, got to know it long ago with the power of curiosity... and google), that 3rd person plural is used when the gender of the 3rd person singular is unknown or variable.

At least this holds true for another Germanic language as well, namely German, neither got deep enough into Spanish nor Japanese to know where which have quite another origin but I'd assume it may hold true for (m)any advanced language(s) and we are simply not aware of it. Heck, even I just do all these different German "the" by mere intuition correctly. I even forgot the rules for all 'em cases that were actually taught quite soon after being taught and I am fairly certain that this holds true for most natives.
#227 by shinnew
2017-06-06 at 20:05
Trying to remove the alias "Matsu Tomohiro" from Kitagawa Samui returns a "500 - Internal Server Error"
#228 by yorhel
2017-06-11 at 16:28
@227: Yeah, that can happen when the alias is still used somewhere, in this case it was referenced from a deleted VN. Fixed with Kitagawa Samui
#229 by wakaranai
2017-11-17 at 05:34
weight of a character is not displayed when it's the only measure specified in profile link

problem seems to be in this line link
#230 by yorhel
2017-11-17 at 06:31
@229: Yup, fixed.
#231 by wakaranai
2018-01-06 at 12:44
great work on bbcode refactoring, now for some bugs :)

some link capturing appears to be more aggressive, not respecting word boundaries: poMinna de Nyan Nyan <- supposed to be "pov1"

got it, when matching the first link in the message it ignores the lack of word boundary.

v123p45Last modified on 2018-01-12 at 23:00
#232 by yorhel
2018-01-06 at 13:46
@231: Heh, I knew I'd break something with that change. Fixed.
#233 by leery
2018-01-08 at 11:34
The bbcode in Jack ~Haitoku no Megami~'s synopsis seems borked now too. Renders verbatim.

[From[url=http://densetsu.com/display.php?id=468&style=alphabetical] Anime Densetsu[/url]]
Last modified on 2018-01-08 at 11:34
#234 by yorhel
2018-01-08 at 16:44
@233: Fixed too. (And possibly broke more at the same time, but I suspect (or hope) that anything I broke now wasn't valid bbcode anyway)
#235 by leery
2018-01-08 at 16:49
Without JavaScript, you get extra commas in character entries: link
#236 by yorhel
2018-01-08 at 16:50
Known issue, too much trouble to fix.
#237 by alto
2018-01-12 at 04:50
Not sure if I'm missing something but searching for Cyclet 5 under releases does not find either r51637 or r53796. The VN search does correctly find VNs linked to those releases. Searching with no space does find r51637 but I'd expect it to ignore spaces and find both like the VN search.
#238 by wakaranai
2018-01-12 at 14:03
^ @yorhel looks like some numbers in queries are considered to be a JAN number link
short arguments are padded with zeroes to fill 12 characters, and then the following check /^[0-9]{12,13}$/ that is supposed to filter short numbers never fails.
#239 by yorhel
2018-01-12 at 14:41
Aye, nice find. The padding-before-check does have a purpose, though: The numbers are stored as an integer in the DB and will need the padding in order to be represented as a valid code. I've compromised on requiring at least 10 digits, it's highly unlikely for a game UPC to have so many leading zeros. And also quite unlikely to accidentally type a correct 10 digit code.

I'd expect it to ignore spaces and find both like the VN search.
While your search query has been fixed with the above change, VN search & release search are still quite different, VN search being much fuzzier. (The only reasons for that difference have been lazyness and avoiding code complexity)
#240 by alto
2018-01-12 at 20:01
Thanks! I had no idea searching by GTIN worked, that's super useful.

I'm no programmer but I did notice link If I'm reading it right, does this mean release search by catalog should work too?
#241 by wakaranai
2018-01-12 at 21:32
^ gg, looks like another bug. it supposed to work that way, yes, but here query string is split in parts on every character from [ -,._] set, so search by catalog number fails because most catalog numbers contain '-' in them.
#242 by leery
2018-01-13 at 03:18
This is probably too obscure and minor to be fixed, but I guess I'll post anyway.

You can over/underrun the screenshot viewer thing.

1) Open the screenshot viewer on a VN entry.
2) Click on 'next' once to focus the link.
3) Press enter to 'click' on the link again.
4) On the last screenshot, the 'next' link goes away, but it still has focus.
5) Press enter once more, and you'll hit the 11th screenshot.
6) ...which manifests itself as a 'Loading...' text and an otherwise empty rectangular screenshot viewer.

7) Same for the 'previous' button.

(Actually, I think the page does an image request to itself for the 11th screenshot. Like, GET /v123. Presumably because the screenshot URL is empty. This, understandably, fails.)Last modified on 2018-01-13 at 03:27
#243 by minah
2018-01-16 at 05:34
When filtering a trait page, changing the spoiler settings resets the filter. Simple enough workaround: filter from the characters page instead (since you can mark spoiler settings in the trait filter section). Still doesn't seem like intended behavior, though.
#244 by leery
2018-01-22 at 14:38
Are deleted tags supposed to be visible in the tag cloud? Because No-Pan shows up in Lime's entry.


You must be logged in to reply to this thread.