Minor error/s

Posted in

#301 by fuukanou
2019-10-13 at 21:24
#300, it's not going to be easy to fix that seeing as there's no marker for Chinese titles on the page. You can guestimate if it's Chinese from original language but you're screwed if it's Japanese & Chinese dual release.

Probably more suited to suggestions unless you can come up with a better wayLast modified on 2019-10-13 at 21:24
#302 by rampaa
2019-10-13 at 21:40
Dual releases are rare and more accuracy is better than nothing. I think when t12465 happens this might be easier to fix.

I am not sure why you are nitpicking about the thread I've posted this.
#303 by yorhel
2019-10-14 at 05:50
Yeah, I should be able to fix that for most entries. Will give it a try later.

EDIT: I've added the HTML 'lang' attribute to most original titles & names now, but it might still need some additional CSS to choose the correct font. I'm not sure to what extend browsers do that automatically.

And we, of course, don't have the information to distinguish between Traditional and Simplified Chinese. :(Last modified on 2019-10-14 at 08:25
#304 by rampaa
2019-10-14 at 14:17
Tested it with Internet Explorer, Edge, Chrome, Opera and Firefox. All of them renders Siwang Zhibo Jian's and Imouto Chu☆ #01 Sunao Imouto no Shou's titles correctly.

As for Traditional and Simplified Chinese, maybe when t12465 goes live we can have separate fields for them?

EDIT: For VNs that have more than one original language, lang attribute seems to be incorrectly selected most of the time. link might help.

Also, it seems like there won't be any (easy) solution for VN/character aliases and character names. :(Last modified on 2019-10-14 at 14:44
#305 by beliar
2019-10-22 at 18:46
Don't know if that's a bug, but now adding staff, the names of the people are squashed in the edit form, meaning a new line is allotted for each name, middle name or surname. It looks weird and it's actually hard to discern where one person's name ends and another's begins.
Example: link
It definitely wasn't like that before.Last modified on 2019-10-22 at 18:47
#306 by yorhel
2019-10-22 at 19:20
Yup, looks like I broke that when reworking the staff editing form (yes, the staff edit form, not the VN staff/cast tabs - leave it up to me to break something unrelated in the process...). Fixed now.
#307 by shinnew
2019-10-26 at 12:07
The Wikipedia (ja) link that was generated by that edit doesn't redirect to the correct Wikipedia page.

Link in Wikidata: link
Link on VNDB: link
#308 by yorhel
2019-10-26 at 12:34
Fixed!
#309 by eacil
2019-10-30 at 12:06
A "," is breaking the name of a linked VN to a release when editing. Example: r53862 "Koi ni" for "Koi ni, Kanmi o Soete"
#310 by skorpiondeath
2019-10-31 at 13:23
With my trembling hand I clicked "submit" while adding a character twice in a row before the page disappeared.
That made me 2 instances of the same character.
It can be easily addressed by disabling submit button inside javascript "onsubmit" event.
I'll just try to click reply twice in a row too... let's see if I get 2 posts.

There is a time block so it did not happen I need to wait 30 sec for post replies :PLast modified on 2019-10-31 at 13:24
#311 by yorhel
2019-10-31 at 13:27
A "," is breaking the name of a linked VN to a release when editing.
Yup, very old bug. I'll be fixing that when I get to rewriting that form (soonish™).

It can be easily addressed by disabling submit button inside javascript "onsubmit" event.
This is also part of my form rewriting improvements. The staff edit form already has it.
#312 by shining17
2019-10-31 at 13:45
link

On the Patreon page.
#313 by yorhel
2019-10-31 at 13:52
I needed to read that 3 times before spotting the mistake...
#314 by fuukanou
2019-11-03 at 04:34
I don't know if this is an error or if it's meant to be like this, but there's no buffer space (like there is between date and user columns) between the user and the page name columns in the edit history on userpages if the username is too long. I just thought it was an oversight because it looked kinda messy and confusing at first glance.

Example can be found here: u135302Last modified on 2019-11-03 at 04:36
#315 by dk382
2019-11-09 at 01:33
Not sure if this has been reported anywhere else, but when linking to some staff database entries in t13122 by their ID, the names came out wrong. Not sure what's up with that.

The staff were Reika, Ryuuguu Daina, and Shiraishi Ryouko. And for the heck of it, I'll toss in Sakurai Hikaru. Let's see if it happens again...

edit: wtf, the first three are wrong again, but Sakurai is correct.

Also, when searching for Sakurai, I noticed that the results came back empty when I got the name order wrong, but it gave me Sakurai's page when I got it right. Is this working as intended?Last modified on 2019-11-09 at 01:34
#316 by yorhel
2019-11-09 at 08:52
@314: Hopefully fixed by making the column sizing more dynamic, let's hope that doesn't screw up the table layout elsewhere. >.>

@315: Oops, bad table join. Fixed!

Also, when searching for Sakurai, I noticed that the results came back empty when I got the name order wrong
It's working as coded, staff & character search is just kind of sucky. I'll see if I can improve that. Sometime. :/Last modified on 2019-11-09 at 08:53
#317 by mikuxdrift
2019-11-09 at 10:47
just wondering if its just me or every history pages looks weird...

no word-break or word wrap is it called? linkLast modified on 2019-11-09 at 12:07
#318 by yorhel
2019-11-09 at 11:29
Aaaargh now I remember why those columns were fixed-width, can't hide excessively long lines otherwise. I hate CSS.
#319 by tahu157
2019-11-09 at 19:20
In the random quote that leads to Chichi Miko!! the word mandatory is missing its n, and the word practice is missing a c.

"In a gal game, sincerely aiming at the heroine you choose is the accepted pratice, the dogma, it's madatory."
#320 by harleyquin
2019-11-10 at 14:53
Searching for "Pin-point" using "Pin Point" or "Pinpoint" doesn't give any hits in the producers tab. Is a wildcard modifier required for entries which use special characters like dashes and underscores?

Reply

You must be logged in to reply to this thread.